Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code structure supporting single source exhort payload to multi source #661

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

IlonaShishov
Copy link
Collaborator

Integrate multi source code structure supporting new exhort response payload.

@IlonaShishov IlonaShishov force-pushed the refactor/multi-source branch 3 times, most recently from aa1330a to ce813d2 Compare November 27, 2023 15:29
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.45283% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (44fc91e) to head (125df8e).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/exhortServices.ts 20.00% 4 Missing ⚠️
src/redhatTelemetry.ts 50.00% 4 Missing ⚠️
src/config.ts 95.45% 0 Missing and 2 partials ⚠️
src/stackAnalysis.ts 95.65% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage   75.63%   85.41%   +9.78%     
==========================================
  Files          10       12       +2     
  Lines         238      288      +50     
  Branches       37       39       +2     
==========================================
+ Hits          180      246      +66     
+ Misses         51       35      -16     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlonaShishov IlonaShishov force-pushed the refactor/multi-source branch 11 times, most recently from 30ca122 to 82e52fc Compare November 30, 2023 13:56
@IlonaShishov IlonaShishov force-pushed the refactor/multi-source branch 4 times, most recently from 03fd430 to 81ef62a Compare December 19, 2023 14:26
IlonaShishov and others added 8 commits December 20, 2023 15:57
* 12/4/23 - ritz303 : Updated the README.md and CHANGELOG.md for Service Preview

* 12/4/23 - ritz303 : Minor edit

---------

Co-authored-by: Aron Gunn <[email protected]>
Signed-off-by: Ilona Shishov <[email protected]>
Signed-off-by: Ilona Shishov <[email protected]>
Signed-off-by: Ilona Shishov <[email protected]>
Copy link
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IlonaShishov IlonaShishov merged commit 629d4c6 into master Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants